Fix some resharper warnings #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5750151873
💛 - Coveralls |
papafe
approved these changes
Aug 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a wide range of warnings/suggestions by ReSharper, primarily in the Realm project. Don't plan to go through the tests at this point, but figured I'd spend 20-30 minutes on the main assemblies. For the most part, those are purely cosmetic and functionally equivalent (e.g. removing usings, marking members private). There are a few categories of warnings that may yield a minor positive impact on users:
readonlyto avoid copying the struct prior to execution (this would have biggest impact on RealmValue and PrimitiveValue).TODO